-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Types: luma.gl Parameters #9209
base: master
Are you sure you want to change the base?
Conversation
Type errors will occur when using non-WebGPU compatible parameters. Perhaps they work now but if so they will soon no longer work Docs at https://luma.gl/docs/api-reference/core/parameters Recommendations:
|
Regarding |
Background
I noticed that that passing
depthTest
inParameters
raises a type error, despite working in the past:Even though luma is not including this on the
Parameters
type, it continues to work in practice.I've gone ahead and added some types to surface the inconsistencies, and found that the following keys are used by deck but untyped in luma:
depthRange
(collision-filter-pass.ts
)depthTest
(terrain-pass.ts
)@ibgreen should these types be added to luma or should deck be migrating to a new API?
Change List
Parameters
type where previously missingisDrawableLayerParameters
type helper